Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly extract titles with multiple line breaks #1874

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

comkieffer
Copy link

Closes #1676 (Starting an entry with multiple line breaks splits the end of the first line by the number of line breaks)

Since the location of the separator was computed on the text.lstrip() but the function returned the substring of text the title would be cut off.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

Since the location of the separator was computed on the `text.lstrip()`
but the function returned the substring of `text` the title would be cut
off.
@comkieffer comkieffer force-pushed the correctly-handle-entries-starting-with-linebreaks branch from 5f4bcbf to 070350f Compare May 25, 2024 17:24
@comkieffer
Copy link
Author

I've rebased this onto the latest develop/. Let's see if the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting an entry with multiple line breaks splits the end of the first line by the number of line breaks
1 participant