Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #51 and is related to some nasty obscure side effects of the policy alteration by the previous implementation, seen in celeritas-project/celeritas#1573.
It's unusual to use
cmake_minimum_required
in a package config file, since it can alter policy scope elsewhere (depending, of course, on the policy that's been set). Thecmake_policy
command correctly scopes the changes to the Config file, rather than applying the change to the rest of the user's code when called from insidefind_package
orfind_dependency
.The updated usage mirrors the CMake-generated
Targets.cmake
file: assertions to check for the rough CMake version, then a scoped policy change for the file itself.