All: add Content-Security-Policy-Report-Only header to all wordpress sites #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
commented
Aug 19, 2024
timmywil
commented
Aug 19, 2024
timmywil
force-pushed
the
csp
branch
2 times, most recently
from
4ce4448 to
c16a9ff
Compare
timmywil
commented
Aug 19, 2024
| <!doctype html> | ||
| <html class="no-js" <?php language_attributes(); ?>> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
|
|
||
| <title><?php | ||
| global $page, $paged; |
There was a problem hiding this comment.
This was a carryover from the default Wordpress header.php, but these variables are not used.
Krinkle
requested changes
Aug 19, 2024
Open
1 task
|
@timmywil Should we limit this to a STAGING conditional at first? The headers hook function could return early when not. |
|
@Krinkle Absolutely. I also didn't mean to set csp instead of the report header. Both are fixed now. |
Krinkle
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref jquery/infrastructure-puppet#54
Ref jquery/infrastructure-puppet#57
This adds a filter that the API sites can override to allow for inline scripts and styles only in API demos.
I'm thinking we can use this in combination with a header set in infrastructure-puppet for non-wordpress sites.