wordpress: set banner via php env var #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
reviewed
Oct 8, 2024
Krinkle
approved these changes
Oct 9, 2024
mgol
approved these changes
Oct 9, 2024
| <%- if @live_site == 'jquery.com' || @live_site == 'api.jquery.com' -%> | ||
| define( | ||
| 'JQUERY_BANNER', | ||
| 'jQuery 4.0 is coming soon! Prepare by <a href="https://jquery.com/download/">upgrading</a> to the latest jQuery 3.x release. Learn more about our <a href="https://jquery.com/support/">version support</a>.' |
There was a problem hiding this comment.
The best way to prepare would be to update to the latest jQuery 3.x, enable Migrate for a while and make sure no warnings are being issued.
One problem with this approach, though, is adding Migrate will also reintroduce jQuery 1.9 behavior in many APIs which is undesirable. I have an issue to tackle this problem in Migrate: jquery/jquery-migrate#472.
For now, this is good, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See companion PR at jquery/jquery-wp-content#468