Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gilded-wordpress to tolerate newer server if semver compatible #39

Closed
Krinkle opened this issue Nov 17, 2023 · 0 comments
Closed
Assignees
Labels
Service: Doc sites WordPress doc sites. Type: Enhancement New feature or request

Comments

@Krinkle
Copy link
Member

Krinkle commented Nov 17, 2023

Right now, the moment gilded-wordpress is updated on the server-side, clients in content repos like api.jquery.com are broken unless all 12 repos are updated at the same time.

Note that in practice, nothing breaks because:

  1. We ignore the lock file (Remove npm update step from builder notifier scripts #38).
  2. These aren't long-running services, so nothing actually "breaks". It just means you have to, at some point, update package.json in a given content repo before you can deploy changes in content from that same repo. The content repos are quite stable, so it's perfectly fine for them to be out of sync for a few weeks until someone actually wants to deploy from them and push a tag. Until then, there's no issue either way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Service: Doc sites WordPress doc sites. Type: Enhancement New feature or request
Development

No branches or pull requests

1 participant