Component: Meter Styling #73
Conversation
Initial Styling for Meter
Initial Styling for Meter
|
I Signed CLA agreement |
| <body> | ||
| <meter max="120" value="50"></meter> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
There is no new line at the end of this file.
…21/css-chassis into 71-base-styling-for-meter
Multicolor value bar.
MultiColor value bar.
1) Add new line at the end 2) MultiColor value bar.
|
New line at the end of the file is added.
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> |
There was a problem hiding this comment.
Please remove this tag: #57 (comment).
<!DOCTYPE html> change to lowercase as mention in the HTML styling guide.
| /* Reset the default appearence */ | ||
| -webkit-appearance: none; | ||
| width: 550px; | ||
| height: 25px; |
There was a problem hiding this comment.
This indentation is wrong (we don't have a SCSS style guide yet but it's kind of already decided that we'll use tabs. It's inconsistent with the rest of the code anyways.)
You'll need to update your git config to include your full name as well as your email address. You can read about it on http://contribute.jquery.org/CLA/status/?repo=css-chassis&sha=f4d3b387aeca6bb43c434f998237a94a899ea7a3#updating-git-config. |
|
|
||
| .meter::-webkit-meter-bar,.MultiColor::-webkit-meter-bar { | ||
| box-shadow: inset 0px 0px 7px -2px rgba(0,0,0,0.35); | ||
| background:#f1f1f1; |
There was a problem hiding this comment.
Needs a space. Like background: #f1f1f1;
Solve all the issue.
Noufal21
force-pushed
the
71-base-styling-for-meter
branch
5 times, most recently
from
1fd83d3 to
94f9e09
Compare
Solve all the issue.
Noufal21
force-pushed
the
71-base-styling-for-meter
branch
from
94f9e09 to
4f6d7ba
Compare
Style new meter name as StripMeter
Do changes according to Jqueru CSS guide.
| <title>Meter Styling</title> | ||
| <link rel="stylesheet" href="../dist/css/chassis.css"> | ||
| </head> | ||
| <body> |
There was a problem hiding this comment.
Per jQuery HTML Style Guide, <body> and <html> tags shouldn't be indented: http://contribute.jquery.org/style-guide/html/#indentation
|
The more I think about it, it might be wise if we're styling |
| @@ -0,0 +1,58 @@ | |||
| // ========================================================================== | |||
There was a problem hiding this comment.
Have file name and folder be spelt with a lower case 'm'
Although that being said, maybe meters should be included with typography? Thoughts?
Resolve all the isssue
| } | ||
|
|
||
|
|
||
| .meter-multicolor:-moz-meter-optimum::-moz-meter-bar { |
There was a problem hiding this comment.
the contents of this selector are basically a direct copy of what you have in webkit implementation above (line 36). Why not just list both selectors up above once so you're not repeating the same contents multiple times in your scss file? It will help make customization easier.
Meter.html => meter.html
change all the nutpicks. :)
|
Per last week's meeting, closing this PR in favor of the approach in #80, since |
Initial Styling for Meter