fix: use LLL instead of MMM to format month in luxon localizer #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is why we have the format props, to allow a developer to override the defaults. Our 'next' version of Big Calendar will use the Intl.DateTimeFormat for formatters, which should be much more accurate. |
|
@rinick You were right, and I apologize for being so hasty. Please resubmit your branch with updated code from master and I will more thoroughly review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Month should be formatted with LLL in Luxon instead of MMM
MMM might work with some of the languages, but not all language
fix #2599