GitHub Actions workflow fixes #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😅 this is going to take some elbow grease. |
tonyarnold
force-pushed
the
visionos-workflow-fixes
branch
4 times, most recently
from
ee30155 to
cff2a37
Compare
This was showing a warning about unsupported node releases
It is failing the SwiftLint analysis workflow
… runner image on GitHub Actions
tonyarnold
force-pushed
the
visionos-workflow-fixes
branch
from
cd15f44 to
380c015
Compare
tonyarnold
force-pushed
the
visionos-workflow-fixes
branch
from
0b5e666 to
91044c1
Compare
tonyarnold
force-pushed
the
visionos-workflow-fixes
branch
from
ff5657f to
c31c96b
Compare
tonyarnold
force-pushed
the
visionos-workflow-fixes
branch
from
c31c96b to
2ecc035
Compare
|
Okay, I believe everything is now running on CI and passing out of the box. I'm more than happy to consolidate commits, or make further changes — just let me know! |
We should only have one of these running and it's already configured for the latest Xcode version on macOS Sonoma.
Since 5.1.3 isn't released yet.
|
Amazing work here @tonyarnold, just a heroic amount of effort to slog through these CI updates. I can't thank you enough for these contributions. I pushed some small changes to your branch and will merge + cut a 5.1.3 release once that passes CI (🤞🤞🤞). |
jpsim
added a commit
to futurejones/Yams
that referenced
this pull request
Jul 10, 2024
tejassharma96
added a commit
to tejassharma96/Yams
that referenced
this pull request
Jul 10, 2024
# By JP Simard (3) and others # Via GitHub * upstream/main: Require Swift 5.7 or later (jpsim#424) Add empty changelog section Release 5.1.3 add support for riscv64 (jpsim#419) Add support for Android (jpsim#421) GitHub Actions workflow fixes (jpsim#422) add os(visionOS) support (jpsim#418) Bazel: support rules_swift 2.x (jpsim#420) Bump rexml from 3.2.5 to 3.2.8 # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the notification spam while I was working on this issue.
This PR proposes fixes for some of the workflow issues introduced with #418, and to update the GitHub Actions workflows where appropriate to use recent versions of Xcode, macOS and the Actions plugins.
This ended up being a wonderful confluence of problems to solve, resulting in the following changes: