Merge pull request #330 from jpsim/jp-remove-uid-cache

remove UID map and lock

Source/SourceKittenFramework/Request.swift

@@ -117,36 +117,13 @@ private let initializeSourceKitFailable: Void = {
 /// dispatch_semaphore_t used when waiting for sourcekitd to be restored.
 private var sourceKitWaitingRestoredSemaphore = DispatchSemaphore(value: 0)
 
-/// SourceKit UID to String map.
-private var _uidStringMap = [sourcekitd_uid_t: String]()
-private var _uidStringMapLock = NSLock()
-
-/// Thread safe read from sourceKitUID map
-private func uidString(`for` sourceKitUID: sourcekitd_uid_t) -> String? {
-    _uidStringMapLock.lock()
-    defer { _uidStringMapLock.unlock() }
-    return _uidStringMap[sourceKitUID]
-}
-
-/// Thread safe write from sourceKitUID map
-private func setUIDString(uidString: String, `for` identifier: sourcekitd_uid_t) {
-    _uidStringMapLock.lock()
-    defer { _uidStringMapLock.unlock() }
-    _uidStringMap[identifier] = uidString
-}
-
 private extension String {
     /**
     Cache SourceKit requests for strings from UIDs
 
     - returns: Cached UID string if available, nil otherwise.
     */
     init?(sourceKitUID: sourcekitd_uid_t) {
-        if let string = uidString(for: sourceKitUID) {
-            self = string
-            return
-        }
-
         let length = sourcekitd_uid_get_length(sourceKitUID)
         let bytes = sourcekitd_uid_get_string_ptr(sourceKitUID)
         if let uidString = String(bytes: bytes!, length: length) {
@@ -161,10 +138,8 @@ private extension String {
             For avoiding those penalty, replaces with enum's rawValue String if defined in SourceKitten.
             That does not cause calling `decomposedStringWithCanonicalMapping`.
             */
-            let uidString = String(uidString: uidString)
-            setUIDString(uidString: uidString, for: sourceKitUID)
 
-            self = uidString
+            self = String(uidString: uidString)
             return
         }
         return nil