Handle load_pem_public_key ValueError #952
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpadilla
requested changes
May 11, 2024
| return cast(RSAPublicKey, load_pem_public_key(key_bytes)) | ||
| try: | ||
| return cast(RSAPublicKey, load_pem_public_key(key_bytes)) | ||
| except (ValueError, UnsupportedAlgorithm): |
There was a problem hiding this comment.
can we add a test that covers this behavior when using the version of cryptography that introduces the behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stab at addressing the issue discussed here: Consider cryptography 42.x.x new validation #948
All I did is raise a
InvalidKeyErrorwhen there is a ValueError andreturn cast(RSAPublicKey, load_pem_public_key(key_bytes))fails.