Interval field

[regisin]

Handles #572

[jowilf]

Hi thank you for the PR, l left some few comments.

Also can we add a converter for Interval in sqlalchemy and timedelta for Odmantic

[jowilf]

I would prefer a view like Dimension in this form https://starlette-admin-demo.jowilf.com/admin/mongoengine/product/create. You can copy form https://github.com/jowilf/starlette-admin/blob/main/starlette_admin/templates/forms/collection.html

[regisin]

Hey, I'm not sure what to do with these converters..what do they do? I just mimic'd the "Time" one:

    @converts("Interval")
    def conv_interval(self, *args: Any, **kwargs: Any) -> BaseField:
        return IntervalField(
            **self._field_common(*args, **kwargs),
        )

Is that it?

[jowilf]

Yes, that's it. The converter's role is to automatically find the appropriate field for each attribute. For SQLAlchemy, it uses the attribute type. Think of it as a map between the attribute type and the corresponding field.

[regisin]

Updated the pr.

[jowilf]

it looks good just some minor comments

[jowilf]

we need to make this optional and require it only when using the Interval field. here is an example:

starlette-admin/starlette_admin/fields.py

Line 863 in 5b183e0

if not arrow: # pragma: no cover

[regisin]

The example is not clear to me. Is the arrow package only imported when using the ArrowField? Looks more like the user cannot use the arrow field if the import fails.

[jowilf]

Yes, the user is not able to use it if the import fails, but they are required to install it before using the field. The idea is to make the arrow package optional, so users who don't want to use ArrowField are not forced to install it.

[jowilf]

this function returns the current user locale

Suggested change

	locale="en",
	locale=get_locale(),

[jowilf]

Suggested change

	@converts(odmantic.bson)
	@converts(odmantic.bson._datetime)

[jowilf]

it seems odmantic does not support timedelta art049/odmantic#120, we can remove this and just keep for sqlalchemy

[regisin]

@jowilf looks like the version of mkdocstring needs attention. I did some digging and found this mkdocstrings/autorefs#57

Either adding this to the mkdoc.yaml:

  - autorefs:
      resolve_closest: false`

or bumping the mkdocstring version: "mkdocstrings[python] >=0.26.1, <0.27.0",

Lets build the docs but gives a bunch of warnings.

[jowilf]

Thank you for the PR, @regisin. I'll look into the mkdocs issue later, as it’s not related to the changes you've made.