-
Notifications
You must be signed in to change notification settings - Fork 101
Rebased variables on WFSerialization. Added variable's with method #47
Conversation
This pull request is still in WIP.
The As always, suggestions are welcome 🙂 |
Date formatting aggrandizements are now fully implemented. @joshfarrant, I'm removing the "To do" checks since they require further discussion.
This one probably requires edits in the CONTRIBUTING guide, since all the current and future actions should have to implement tests for cases where
The actual This pull request is now complete. The aggrandizement system now misses only the get parameter, I'll add it in the third and last step of this process since it requires more work: the only way to implement it correctly and thoroughly is by creating 251 aggrandized variables with all the combinations I listed here and by parsing each one of them to get the right This pull request can be now reviewed and, if there won't be suggestions or issues, merged. 🙂 |
Thanks @xAlien95, I’ll take a proper look at this over the weekend. |
🎉 💙 |
Checks
Added Actions (if relevant)
Are you happy to be listed as a contributor on Shortcuts.fun?
Yes
Any other information / comments
WFSerialization
Variable class
with a.with()
method for AggrandizementsAggrandizement
types.with()
method, with some examplesContributors that have to implement actions that accept variables as parameters only need to add
WFSerialization
as additional type for that particular parameter (#27 (comment)), whilst users have to simply insert the variable:Regarding
.with()
, its parameters are just the same that Shortcuts provides.I put the coercion type under the
type
parameter: