isColorSupported is showing TRUE for non-tty Windows terminals #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check TTY support for windows terminals
jorgebucaran
reviewed
Jan 5, 2023
|
|
||
| const isCI = | ||
| "CI" in env && | ||
| ("GITHUB_ACTIONS" in env || "GITLAB_CI" in env || "CIRCLECI" in env) | ||
|
|
||
| export const isColorSupported = | ||
| !isDisabled && | ||
| (isForced || (isWindows && !isDumbTerminal) || isCompatibleTerminal || isCI) | ||
| (isForced || (isWindows && !isDumbTerminal && isTty) || isCompatibleTerminal || isCI) |
There was a problem hiding this comment.
Could we achieve the same result by checking isCompatibleTerminal earlier?
There was a problem hiding this comment.
I think not, isCompatibleTerminal will return false both when run through non-TTY GUI app and when through command line directly on Windows. And it seems like Windows console is never TTY either while checked through nodejs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exported
isColorSupportedproperty returns wrong value (true) for Windows terminals that has no TTY support, such as Visual Studio Code Output window, etc. That affects libraries, like lint-staged, who rely on it.The code below should return
falsefor VS Code Output window, but instead returns true:node -e "console.log(require('colorette').isColorSupported)"This PR enhances this behavior, by adding additional TTY support check.