Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EOL Node versions from workflow #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jorgebucaran
Copy link
Owner

@jorgebucaran jorgebucaran added the enhancement New feature or request label Jan 22, 2024
@jorgebucaran jorgebucaran self-assigned this Jan 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0928e67) 100.00% compared to head (646bb6a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          150       150           
=========================================
  Hits           150       150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jorgebucaran
Copy link
Owner Author

What should we do about our legacy tests? Would it be more sensible to use older GitHub Actions specifically for those tests, or should we consider removing them altogether?

cc @Fdawgs @kibertoad

@kibertoad
Copy link
Collaborator

Can you remind me if legacy tests provide extra coverage over what non-legacy tests do, that you consider useful?

@jorgebucaran
Copy link
Owner Author

I remember that the legacy tests are the same but run on older Node.js versions. However, on closer inspection, they do include some environment tests not present in the current tests haha.

@kibertoad
Copy link
Collaborator

we should migrate them, then, and then we can drop the legacy ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants