Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tabs ignoring useCookie param #6861

Closed
wants to merge 1 commit into from

Conversation

jjdelvalle
Copy link

Not sure why they were strings before. They're assumed to be booleans later on when they're used in JS at this line: https://github.com/joomla/joomla-cms/blob/staging/media/system/js/tabs.js#L45

Reason for not removing the true and false values since they're redundant: joomla/coding-standards#88

Steps to reproduce

  1. Create tabs using something like this echo JHtml::_('tabs.start', 'signInPane', array('startOffset' => 2, 'useCookie' => false)); and anything else that's necessary to create the rest of the tabs pane.
  2. Visit the tabs on the frontend.

Expected result

Have the 3rd tab (because of zero indexing) be open. And upon selecting another tab and refreshing, have the 3rd tab still open, and not the last active tab.

@jjdelvalle
Copy link
Author

This was giving me a headache, and apparently I'm not the first one:
http://joomla.stackexchange.com/questions/5675/how-do-i-set-options-for-jhtmltabs-with-bootstrap

@gunjanpatel
Copy link
Contributor

This fix is already sent and tested successfully one time #6080 need one more test there. :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6861.

@roland-d
Copy link
Contributor

roland-d commented May 6, 2015

@clinchergt Thank you for your contribution. I am closing this PR in favor of #6080 as this already has a test.

@roland-d roland-d closed this May 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants