Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix duplicate entry with the action logs by removing the second call to onJoomlaAfterUpdate #44629

Open
wants to merge 1 commit into
base: 5.2-dev
Choose a base branch
from

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Dec 17, 2024

Summary of Changes

Fix duplicate entry with the action logs by removing the second call to onJoomlaAfterUpdate

Testing Instructions

  • Install the latest version of Joomla
  • Check the action logs
  • Reinstall the core from com_joomlaupdate
  • Check the action logs again
  • change the update server to this generated one: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/44629/downloads/80905/pr_list.xml
  • Install the update
  • check the action logs again
  • reinstall the core files
  • check the action logs again

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Dec 17, 2024

I have tested this item ✅ successfully on 99cf048

Test by prebuilt package:
Untitled


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44629.

@alikon
Copy link
Contributor

alikon commented Dec 17, 2024

I have tested this item ✅ successfully on 99cf048


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44629.

@alikon
Copy link
Contributor

alikon commented Dec 17, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44629.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 17, 2024
@richard67 richard67 changed the title [5.2] Fix dublicate enty with the action logs by removing the seccond call to onJoomlaAfterUpdate [5.2] Fix duplicate enty with the action logs by removing the seccond call to onJoomlaAfterUpdate Dec 17, 2024
@richard67 richard67 changed the title [5.2] Fix duplicate enty with the action logs by removing the seccond call to onJoomlaAfterUpdate [5.2] Fix duplicate entry with the action logs by removing the second call to onJoomlaAfterUpdate Dec 17, 2024
@zero-24
Copy link
Contributor Author

zero-24 commented Dec 17, 2024

Thanks you both that was fast 👍

@laoneo
Copy link
Member

laoneo commented Dec 17, 2024

Just wondering why it was called twice at all and this todo survived so long.

@zero-24
Copy link
Contributor Author

zero-24 commented Dec 17, 2024

Just wondering why it was called twice at all and this todo survived so long.

I'm wondering the same i have also noticed all the "Updated from Unknown to XX" messages but never looked deeper until this night where i used the plugin event myself ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-5.2-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants