-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Add user argument to perform the cli command with a specific user #44618
Open
laoneo
wants to merge
9
commits into
joomla:5.3-dev
Choose a base branch
from
Digital-Peak:cli/user
base: 5.3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandewt
reviewed
Dec 13, 2024
Surely there must be some sort of authentication required |
Not on cli |
brianteeman
reviewed
Dec 14, 2024
@laoneo You saw that unit tests are failing? |
Yes, as long as we are still discussing things I will not make more changes |
sandewt
reviewed
Dec 14, 2024
Co-authored-by: Brian Teeman <[email protected]>
Co-authored-by: jsanders <[email protected]>
This is correct. But I changed the code and to have a more real world test scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Sometimes is a user needed when running console commands. As cli per se doesn't know a user, this pr adds a new user argument, when set, does the console application load a user object before executing the command. The argument has the name
--user
and accepts either the user id or username.Testing Instructions without the patch
php cli/joomla.php user:reset-password --username test --password newpw
Testing Instructions with the patch
--user
argument (replace manager with a username from your system):php cli/joomla.php user:reset-password --user manager --username test --password newpw
Actual result BEFORE applying this Pull Request
The username got changed but no action log entry was made and log in on the front is possible.
Expected result AFTER applying this Pull Request
The username got changed and an action log entry was made for the user manager that he changed the user test and log in on the front is possible.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed