[5.3] logical css associations sidebyside #44613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use logical CSS properties to avoid having to set different LTR and RTL css Previously browsers didnt support logical css properties for floats. They do now https://caniuse.com/?search=float-inline There should be no visible difference after this PR Switch to an RTL language As this is a scss change then you will need to either rebuild the css or test with a prebuilt package Signed-off-by: BrianTeeman <[email protected]>
joomla-cms-bot
added
NPM Resource Changed
|
I have tested this item ✅ successfully on 99d0d9f 5.2.2-stable
Prebuilt package
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44613. |
|
setting RTC cause it was successfully tested by @Quy too |
joomla-cms-bot
removed
NPM Resource Changed
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44613. |
alikon
added
NPM Resource Changed
alikon
added
PR-5.3-dev
RTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Use logical CSS properties to avoid having to set different LTR and RTL css
Previously browsers didnt support logical css properties for floats. They do now https://caniuse.com/?search=float-inline
Testing Instructions
Switch to an RTL language
As this is a scss change then you will need to either rebuild the css or test with a prebuilt package
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
There should be no visible difference after this PR
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed