Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] allow + rawurldecode #44609

Open
wants to merge 1 commit into
base: 5.3-dev
Choose a base branch
from

Conversation

brianteeman
Copy link
Contributor

Replacement PR for #39917

Summary of Changes

replaces urldecode with rawurldecode

rawurldecode() prints the plus sign per RFC3986 requirements. (urldecode(0 follows the RFC1866 spec and allows pluses to be decoded as spaces in the query part of the URL only)

Testing Instructions

No idea

@Hackwar the reasoning makes sense to me but I don't know if there are consequences

Actual result BEFORE applying this Pull Request see #22096

Expected result AFTER applying this Pull Request

see #22096

original pr was closed after 6 months of inactivity and the issue was not re-opened so here is a second attempt to fix the bug

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Replacement PR for joomla#39917

### Summary of Changes
replaces urldecode with rawurldecode

rawurldecode() prints the plus sign per RFC3986 requirements. (urldecode(0 follows the RFC1866 spec and allows pluses to be decoded as spaces in the query part of the URL only)

### Testing Instructions
No idea

@Hackwar the reasoning makes sense to me but I don't know if there are consequences

### Actual result BEFORE applying this Pull Request
see joomla#22096

### Expected result AFTER applying this Pull Request

see joomla#22096

Signed-off-by: BrianTeeman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants