Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Admin: Contact view does not load with a large user base #44600

Open
wants to merge 1 commit into
base: 5.3-dev
Choose a base branch
from

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #41187 .

Summary of Changes

This PR removes the ability when using batch functions to set/change the linked user. As this loads all users on the site into a giant list it impacts performance of all functionality in the contact component list view. With enough users it can even prevent the page from loading.

I can't see a valid use case for even having the functionality to link multiple contacts to the same user.

The field to select the users is therefore removed from the batch modal and the related files and strings are therefore marked as deprecated without replacement

Testing Instructions

Open the batch modal for the contact manager

Actual result BEFORE applying this Pull Request

Option to mass set linked user

Expected result AFTER applying this Pull Request

Option no longer present

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Dec 10, 2024
@fgsw
Copy link

fgsw commented Dec 10, 2024

I have tested this item ✅ successfully on f5db2d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.

@obuisard
Copy link
Contributor

I have tested this item ✅ successfully on f5db2d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.

1 similar comment
@AndySDH
Copy link
Contributor

AndySDH commented Dec 10, 2024

I have tested this item ✅ successfully on f5db2d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PR-5.3-dev labels Dec 10, 2024
@alikon
Copy link
Contributor

alikon commented Dec 10, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44600.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 10, 2024
@richard67 richard67 added Language Change This is for Translators PR-5.3-dev labels Dec 11, 2024
@laoneo
Copy link
Member

laoneo commented Dec 12, 2024

I know this is more a user backwards compatibility break and doesn't fall into our bc policy. If necessary I would like to remove stuff only in a major version, except when it is urgent, which is here not the case. An admin can do a layout override now till 6.0 is released.

@brianteeman
Copy link
Contributor Author

I disagree. This is a bug fix. Telling someone to create an override to fix a bug is not the correct thing to do. As per the original bug report this useless function prevents the correct operation of anything in the com_contact list view as the query is run on page load and not just when the modal opens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants