Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Optional content.prepare on text fields #44597

Open
wants to merge 2 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Dec 10, 2024

Pull Request for Issue #42824 .

Summary of Changes

Add a field param to the text field plugin to allow content.prepare plugins such as mailcloak to process the field

Testing Instructions

Create a text field for an article
Enter an email address into the article
Check the output of the article and see if the email address is cloaked

Actual result BEFORE applying this Pull Request

Email address is plain text

Expected result AFTER applying this Pull Request

Email address is plain text
Change the field value in the text field plugin to Yes - the email address is cloaked
Change the field value in the field to No - the email address is not cloaked
Change the field value in the field to Yes - the email address is cloaked

image

image

This is fully b/c as the content.prepare is not enabled by default

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <[email protected]>
@Fedik Fedik added the Feature label Dec 10, 2024
@fgsw
Copy link

fgsw commented Dec 10, 2024

I have tested this item ✅ successfully on 411a9be

Comment:

#### Test instructions:
Change the field value in the field to Yes - the email address is not cloaked
#### Test result:
Change the field value in the field to Yes - the email address is cloaked.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44597.

@brianteeman
Copy link
Contributor Author

@fgsw thanks I fixed the error in the test instructions

@alikon
Copy link
Contributor

alikon commented Dec 16, 2024

setting RTC cause it was successfully tested by @Quy too

@alikon
Copy link
Contributor

alikon commented Dec 16, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44597.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 16, 2024
@alikon alikon added the Feature label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Language Change This is for Translators PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants