Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5]log edit contact from frontend #44596

Open
wants to merge 6 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Dec 9, 2024

Pull Request for Issue #44589 .

Summary of Changes

add log entry when edit a contact from frontend

Testing Instructions

  • Make sure the Contacts component is enabled in the User Action Logs global configuration
  • Display a Contact via the frontend (eg. via menu item)
  • Edit the contact and save

Actual result BEFORE applying this Pull Request

No action is recorded.

Expected result AFTER applying this Pull Request

An action for the contact updated is added to the Action Log

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review December 9, 2024 11:34
@alikon alikon changed the title log_edit_contact_frontend [5]log edit contact from frontend Dec 9, 2024
@AndySDH
Copy link
Contributor

AndySDH commented Dec 9, 2024

Tested partially successfully. With the current state of the PR, I get a double entry in the User Action Log every time you save a contact.

I think the change you made to ContactController.php is not needed.

If I remove the change made to ContactController.php, then it works fine with just one entry in the Action Log when saving a contact.

@alikon
Copy link
Contributor Author

alikon commented Dec 9, 2024

@AndySDH you are right should be Ok now

@AndySDH
Copy link
Contributor

AndySDH commented Dec 9, 2024

I have tested this item ✅ successfully on af3f257

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44596.

@Fedik Fedik added the Feature label Dec 9, 2024
@fgsw
Copy link

fgsw commented Dec 11, 2024

I have tested this item ✅ successfully on af3f257

Test by using prebuilt package.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44596.

@alikon
Copy link
Contributor Author

alikon commented Dec 11, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44596.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 11, 2024
@Fedik Fedik added the Feature label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants