Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Move code to log model in new scheduler history view #44587

Open
wants to merge 6 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Dec 6, 2024

Summary of Changes

This is a followup for #42530 which uses the existing functions of the MVC API and removes some duplicated code. Like that are all ACL checks done, the default events triggered and code looks more inline with the rest of the core.

Testing Instructions

  • Run a task
  • Open the new task history view
  • Delete a log entry
  • Clear the whole history

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Dec 6, 2024
@laoneo laoneo changed the title Move to log model [5.3] Move code to log model in new scheduler history view Dec 6, 2024
@alikon
Copy link
Contributor

alikon commented Dec 7, 2024

just applied the pr and runned a default task

image

@laoneo
Copy link
Member Author

laoneo commented Dec 7, 2024

Please check the response of the ajax request in the browser console. What for an error did you get?

@alikon
Copy link
Contributor

alikon commented Dec 7, 2024

Call to undefined method Joomla\CMS\Document\JsonDocument::getToolbar()

@laoneo
Copy link
Member Author

laoneo commented Dec 7, 2024

Set your server into debug mode and post the whole stack trace please.

@alikon
Copy link
Contributor

alikon commented Dec 7, 2024

my fault there was an obsolete plugin listening onBeforeRender

@alikon
Copy link
Contributor

alikon commented Dec 7, 2024

I have tested this item ✅ successfully on 7bbfc2a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.

@alikon alikon mentioned this pull request Dec 11, 2024
4 tasks
@HLeithner HLeithner added b/c break This item changes the behavior in an incompatible why. HEADS UP and removed b/c break This item changes the behavior in an incompatible why. HEADS UP labels Dec 16, 2024
@exlemor
Copy link

exlemor commented Dec 16, 2024

I have tested this item ✅ successfully on f9bfbdf

I have successfully tested this as instructed. Worked beautifully.

Thanks laoneo.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.

@laoneo
Copy link
Member Author

laoneo commented Dec 16, 2024

As I added only types, removed an obsolete string and alpha ordered the new strings, I mark this as RTC because it needs to go into an alpha.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.

@laoneo
Copy link
Member Author

laoneo commented Dec 16, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44587.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants