[5.3] Code cleanup #44586
Open
[5.3] Code cleanup #44586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
reviewed
Dec 5, 2024
| @@ -52,13 +52,13 @@ public function thumb($template, $clientId = 0) | |||
| $template->xmldata = TemplatesHelper::parseXMLTemplateFile($client->id === 0 ? JPATH_ROOT : JPATH_ROOT . '/administrator', $template->name); | |||
| } | |||
|
|
|||
| if ((isset($template->xmldata->inheritable) && (bool) $template->xmldata->inheritable) || isset($template->xmldata->parent)) { | |||
| if (isset($template->xmldata->parent) && (string) $template->xmldata->parent !== '' && file_exists(JPATH_ROOT . '/media/templates/' . $client->name . '/' . (string) $template->xmldata->parent . '/images/template_thumbnail.png')) { | |||
| if ((isset($template->xmldata->inheritable) && $template->xmldata->inheritable) || isset($template->xmldata->parent)) { | |||
There was a problem hiding this comment.
is it not better to cast the value of inheritable to a boolean. This ensures that any non-boolean value is explicitly converted to true or false otherwise the value is evaluated in its original type ???
There was a problem hiding this comment.
It's implicitly coerced to boolean, that's why the type cast is redundant. See https://www.php.net/manual/en/language.types.type-juggling.php
richard67
reviewed
Dec 5, 2024
administrator/components/com_menus/src/Model/MenutypesModel.php
Outdated
Show resolved
Hide resolved
janschoenherr
force-pushed
the
patch-18
branch
3 times, most recently
from
c9d4371 to
b3b5b05
Compare
janschoenherr
force-pushed
the
patch-18
branch
from
b3b5b05 to
fc8d2d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
dirname(__FILE__)with__DIR__Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed