Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix $language default parameter #44575

Open
wants to merge 1 commit into
base: 5.3-dev
Choose a base branch
from

Conversation

janschoenherr
Copy link
Contributor

@janschoenherr janschoenherr commented Dec 3, 2024

Summary of Changes

It's the same commit as the one below, but for all get*Route() functions I could find.

#39434

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@N6REJ
Copy link
Contributor

N6REJ commented Dec 9, 2024

Testing instructions are needed

@janschoenherr
Copy link
Contributor Author

@N6REJ I don't think there is much, that can be tested here.

Copy link
Member

@richard67 richard67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t it be string instead of mixed?

components/com_contact/src/Helper/RouteHelper.php Outdated Show resolved Hide resolved
@alikon
Copy link
Contributor

alikon commented Dec 16, 2024

it was successfully tested by @Quy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants