-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] Added possibility to batch remove a tag #40613
Conversation
I have tested this item 🔴 unsuccessfully on d9bf8bf There is no "joomla.batch-tag-addremove" asset of a "script" type in the registry. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40613. |
Hi @crommie, thanks for testing. |
OK in that case I can't re-test since I'm testing on a PBF server site. |
I have tested this item ✅ successfully on ba2293d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40613. |
I have tested this item ✅ successfully on ba2293d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40613. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40613. |
This pull request has been automatically rebased to 5.1-dev. |
…nto beni71-23185
@softforge Thanks for helping me.
Does it mean that I have to create a PR for the version 5.x as well? If so, shouldn't the deprecation messages be adapted to something like: deprecated 5.x will be removed in 7.0 ? |
@beni71 yes you would need to get something in 5.* for deprecation in 7. As soon as we see a pr against 5.2, we can merge this one. Thanks for the time and work on this. We can help test that and discuss with the RM for that release. |
@softforge @Bodge-IT Meanwhile @beni71 has made a PR for 5.2-dev: #44383 . But as far as I understand your comments above, you just wanted to have the deprecation of the old method |
You are right and I have commented on #44383 |
Appreciate all your work and patience on this @beni71. Finally merged. |
please create a migration entry in the manual for 6.0 |
Pull Request for Feature request #23185 .
Summary of Changes
In the articles view there is a batch action which can add/assign one tag from the tag list to the selected articles. This PR introduces the possibility to remove/unassign one tag from the selected articles. It also extends batch processing for categories, contacts and news feeds.
How it looks like:
Testing Instructions
If you use patch tester, after applying the patch, call
npm install
from commandline to rebuild the .js files in folder media.Actual result BEFORE applying this Pull Request
It is not possible to remove/unassign a tag from an article via batch processing.
Expected result AFTER applying this Pull Request
It is possible to remove/unassign a tag from an article via batch processing.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
There are new text keys that need to be translated.