-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] remove deprecated strings #40296
Conversation
This PR removes language strings marked for deprecation in 5.0
This reverts commit 6d76cdfb4cbf54b06a18fab7b17aa8a27098e0e8.
@HLeithner there are a few more strings marked for removal in #39374 which related to |
did @richard67 removed the files from #39431 already in a 5.0 PR? |
@HLeithner No, I haven't done that yet. Shall I do that? |
yes please |
@HLeithner See PR #40302 . |
I have tested this item ✅ successfully on 996c306 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40296. |
@brianteeman since @richard67 brings this up in the other PR could you create a PR against the 5.0 branch in the manual please? joomla/Manual#28 Add a section to the b/c incompatible file |
with a pr against a pr? |
it's the 5.0 branch in the manual repo |
@brianteeman Harald means the https://github.com/joomla/Manual/blob/5.0/migrations/44-50/removed-backward-incompatibility.md file. |
Thanks @richard67 |
@brianteeman Now you only need to adapt the last 2 check boxes in the "Link to documentations" section of the description. The "Pull Request link for manual.joomla.org: " should be checked, and the link to joomla/Manual#101 should be added at the end, and the other checkbox below that should be unchecked. |
@@ -219,15 +219,7 @@ COM_USERS_MAIL_MASSMAIL_MAIL_TITLE="Users: Mass Mail Users" | |||
COM_USERS_MAIL_NO_USERS_COULD_BE_FOUND_IN_THIS_GROUP="No users could be found in this group." | |||
COM_USERS_MAIL_ONLY_YOU_COULD_BE_FOUND_IN_THIS_GROUP="You are the only user in this group." | |||
COM_USERS_MAIL_PASSWORD_RESET_DESC="Sent to a user by the "Forgot your password?" link eg in a login form." | |||
COM_USERS_MAIL_PASSWORD_RESET_TITLE="Users: Password Reset" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think the string below is the one deprecated not the one above this line :)
This PR removes language strings marked for deprecation in 5.0
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed