[4.1] Simplify statistic plugin

[bembelimen]

Based on the minutes from 19th October 2021 I recreated the statistic plugin:

• Removed the "once" button, as this option is not really useful for the statistics.
• Made more clear which data are sent (made the link to open up information more prominent)
• Pointed out, that the data are anonymous

Before

Now

[Kubik-Rubik]

Please also update the JavaScript code (media/plg_system_stats/js) of this plugin to reflect the "once" removal.

[chmst]

I have tested this item ✅ successfully on 669cf52

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35983.}

[bembelimen]

Please also update the JavaScript code (media/plg_system_stats/js) of this plugin to reflect the "once" removal.

Good find, thx, is fixed.

[brianteeman]

The english changes here are not very good and they are sending the wrong message. I agree about removing the send once but the rest is not correct. Also it is not clear what happens to sites that have previously said "once" when the plugin is updated.

[bembelimen]

The english changes here are not very good and they are sending the wrong message.

thanks for the feedback, could you elaborate on that? What would you change?

Also it is not clear what happens to sites that have previously said "once" when the plugin is updated.

Nothing, as they sent it already and now the plugin is disabled.

[brianteeman]

Also it is not clear what happens to sites that have previously said "once" when the plugin is updated.

Nothing, as they sent it already and now the plugin is disabled.

then the quality of the stats will not improve

[bembelimen]

then the quality of the stats will not improve

Not for the old one, but for the new one. It's all about sending regular data. "Once" is a "no" for regular data. I personaly would have prefered a opt-out solution and collecting more (anonymous) data, but this was just not possible. So the solution is to get more people clicking on "yes" by being more detailed.

[brianteeman]

Honestly its a waste of time. This will have minimal impact on improving the statistics and their usefulness. More people will not be clicking on yes because the majority of people will never see it. The only way to do that would be to reset the plugin status when this new version is installed and ask EVERYONE the question.

[HLeithner]

Honestly its a waste of time. This will have minimal impact on improving the statistics and their usefulness. More people will not be clicking on yes because the majority of people will never see it. The only way to do that would be to reset the plugin status when this new version is installed and ask EVERYONE the question.

I like the idea to reset the current status of the plugin if it is set to "once".

[chmst]

My2cent: 2 buttons, left no, right yes are a good solution.

Eyes (in ltr countries) go from left to right and stay on the most right button. This is why all consent messages have the "yes" button right. So I think that changing the order of buttons will have an impact.

Deciding between 2 alternatives is easy, 3 options make the user think. A normal user cannot know what's the difference between options always and once. What means "once"?

[Krshivam25]

I have tested this item ✅ successfully on 40ee732

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35983.}

[zero-24]

Suggested change

	PLG_SYSTEM_STATS_BTN_SEND_ALWAYS="Yes, I'll help Joomla!"
	PLG_SYSTEM_STATS_BTN_SEND_ALWAYS="Yes, I'll send statistics"

[HLeithner]

I'm I the only one that would the yes button expect on the left side? Maybe I'm brain washed by windows but the primary button is always left (on windows) I think mac is diffrent?

[brianteeman]

Its all irrelevant if we dont reset the plugin

[zero-24]

I'm I the only one that would the yes button expect on the left side? Maybe I'm brain washed by windows but the primary button is always left (on windows) I think mac is diffrent?

Thats another argumend raised by me on the discussion before so its not just you...

[zero-24]

Its all irrelevant if we dont reset the plugin

Do we have the right to reset such thing? The decison to only send them once (while it does not make much sense) is a decision we have to respect right? Now its gone and the most accurate replacement is the new "no" option, IMO we should have disabled the plugin on the "no" and "only once" button click in the first place to be correct so here just reset the thing.

If we want to I would say the only thing we should do would be to ask for a new decision on the "only once" users but keep the "no" decision intact.

[zero-24]

You know that atleast in germany the IP is interpreted as identifying data so just tell them that technically we collect the IP but do not use that.

[zero-24]

And as noted above the "no" button should go and disable the plugin all together there is no point in running that plugin all the time when its not sending anything at all.

[HLeithner]

I think the plugin should use the task scheduler... ok sorry a bit offtopic^^

Resetting "only once" should be ok, because this options doesn't exists anymore. The other options should be as they are now. On the other side you can argument that "only once" means for us "no" after this... don't care if it's only for new installation it's fine for me too.

[brianteeman]

The IP of the server is not PII just the users internet connection IP

[richard67]

@Shubhamverma2796 I can see a positive test from you counted for this pull request, but it seems you have not used the "Test this" button in the issue tracker to submit your test result, you have used the "Alter test" button, so we can see that only in the issue tracker but not on GitHub.

If you have really tested this PR, then please use the "Test this" button in the issue tracker https://issues.joomla.org/tracker/joomla-cms/35983 to submit your test result.

In the issue tracker and on GitHub you will see than a comment like this:

The "alter test" button is meant to correct a previously submitted test result, e.g. in case if you have forgotten to select the appropriate result before submitting.

Thanks in advance.

[ditsuke]

I have tested this item ✅ successfully on 236b5eb

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35983.}

[softforge]

I have tested this item ✅ successfully on 236b5eb

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35983.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35983.}

[brianteeman]

On the other side you can argument that "only once" means for us "no" after this...

That's why it is the way it is now. If we reset "only once" (which means once then never), we could reactivate all plugins ... Which means we have to republish it and set the parameter.
I have no feelings about this additional step, if someone delivers the code.

If we don't reset then we will not get any improved stats and this PR is pointless.

I see no issue in doing this. It will not break the site.

[bembelimen]

So I thought a lot over if we should reset the decisions the user made (at least for "once") or not.
At the end I think, that the "once" was a decision of the user to not send regular data, so we should respect it. Also was the idea of the PR only to improve the text.

So I will go with the current version.

[brianteeman]

Your choice of course but the plugin is still producing (or more accurately not producing) any usable statistics

[bembelimen]

Your choice of course but the plugin is still producing (or more accurately not producing) any usable statistics

I don't disagree, but that was not the intention of this PR. Probably for 4.2 a complete rewrite could happen. @fancyFranci @roland-d

[roland-d]

A rewrite is fine but first we need a description of what it should be doing, otherwise there is no use doing a rewrite. We need to have a list of requirements that the plugin should fulfill. If we do that, are we actually using the data collected...

[zero-24]

I still disagree with the texts using suggestive language, its a bad sign to me that we think we have to use such suggestive language to gather questionable statistics.. :(

[brianteeman]

Just to point out that while the joomla stats only show 3% on j4.
Stats from akeeba show ten times that number.

[zero-24]

Jup but that is not fixed by just changing the language and removing the once option. And as mentiond by Nic the serverside (of our statistics) have to be changed too like invalidate old reports etc.

And we have to keep in mind that even when its widly used akeeba is not installed on all sites but maybe more specificly used on well maintained sites.

[brianteeman]

I've not said remove the once option. Just that we should ask again (even if they said once in the past) for a major new release.

I thought the serverside part of the stats had been updated sometime ago to invalidate any reports from more than x ago

Of course akeeba stats will be skewed towards the higher end. But its a good indicator that the stats we have and supposedly use to determine various things are way off

[zero-24]

I'm not aware of any such change on the serverside but lucky me not everything goes via my desk. :-D

By the commit logs we only had php and joomla version changes latly.

[brianteeman]

I must have been thinking of this joomla/statistics-server#60

[zero-24]

Possibly :-)

[cyrezdev]

I agree with @brianteeman about reset for all, as the plugin will be changed. If the message is clear about why Joomla needs stats, it will have more effect, and some may say yes when they click no by the past.
In case of update, it would need maybe an additionnal information message (alert) to inform why we ask again.