Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server changelogurl not working properly #43505

Open
robbiejackson opened this issue May 21, 2024 · 4 comments
Open

Update server changelogurl not working properly #43505

robbiejackson opened this issue May 21, 2024 · 4 comments

Comments

@robbiejackson
Copy link

Steps to reproduce the issue

Set up an extension server type update server as described in https://docs.joomla.org/Deploying_an_Update_Server. Include a changelogurl element which points to a changelog XML file.

Set up a changelog XML file as described in https://docs.joomla.org/Adding_changelog_to_your_manifest_file

In the admin back-end Update / Extensions click on Check For Updates.

The update should appear, and should have a blue Changelog button.

Click on the blue Changelog button.

Expected result

It should display the changelog entries from the changelog XML file on the update server.

Actual result

It shows the changelog title, but no content

System information (as much as possible)

Joomla 5.1

Additional comments

When the changelog button is pressed it triggers an http request to
index.php?option=com_installer&task=manage.loadChangelogRaw&eid=258&source=update&format=raw

This runs in particular the loadChangelog function in com_installer ManageModel.

The code queries the database to find the changelogurl field in the extensions table. Because the wasn't set in the installer manifest XML file, this field is blank. So it doesn't display any change log.

I believe that the code should instead use the changelogurl field in the udpates table. This is correctly set from the update server.

Developers may have different changelog XML files for different versions of their extension. This may mean they'll have different changelogurl entries for installed extensions and updates. So for updates Joomla should use the changelogurl field in the updates table (ie for the extension update) rather than the one in the extensions table (the changelog for the currently installed version).

@ClausKiss
Copy link

Had the same issue. In my case the Austrian ö, ü etc. were the issue. Included them into <![CDATA[...]] and it worked


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43505.

@Hackwar Hackwar added the bug label Nov 28, 2024
roland-d added a commit to roland-d/joomla-cms that referenced this issue Dec 16, 2024
@roland-d
Copy link
Contributor

Hi @robbiejackson I have created a fix for this problem, if you could that test that, that would be great. PR is here:
#44626

@alikon
Copy link
Contributor

alikon commented Dec 16, 2024

closing as we have a pr to test #44626

@alikon alikon closed this as completed Dec 16, 2024
@robbiejackson
Copy link
Author

The PR #44626 doesn't (currently) address this issue, so I don't think it should be closed at this stage.

@alikon alikon reopened this Dec 16, 2024
roland-d added a commit to roland-d/joomla-cms that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants