This repository has been archived by the owner on Mar 17, 2020. It is now read-only.
Improve transition generic.select list in articles overview #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On articles overview, every article gets a generic select list for transitions. These select lists have all the same id.
This PR gives every select list an own id.
It gives class "custom-select" and improves the layout.
Testing instructions
Make a worflow with several states and transitions, make a category which use this workflow.
Add some articles to this category.
See the Overview - every article has a select list for Transitions.
Expected result
Open the source in the browser - dropdowns must have unique IDs
Actual result
All dropdowns have the same ID
Apply the Patch.
IDs are now unique.
The layout is improved.
Documentation Changes Required
No