Skip to content
This repository has been archived by the owner on Mar 17, 2020. It is now read-only.

Implementing diagram representation for workflows #152

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

Buddhima
Copy link
Contributor

Summary of Changes

This implementation adds diagram representation of a workflow. A sample diagram ins as follows (taken from Joomla! Default workflow:
image

This implementation uses following color indexing:
green - Published condition states
red - Trashed condition state
yellow - Unpublished condition states

This should actually go into a separate template in tmpl\workflow folder. Unfortunately because an error in tab view (should be fixed in core), this is added after workflow description.

Testing Instructions

Create a workflow and add few states and transitions. Open the workflow's Description tab and scroll down.

Copy link

@jjaracz jjaracz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obraz
There should be check-in if user creates workflow or not because we can not render diagram for workflows that does not have any transactions.

@Buddhima
Copy link
Contributor Author

@jjaracz , Thanks for pointing out. Updated PR with check for new workflows.

@jjaracz
Copy link

jjaracz commented Nov 12, 2017

I have a strange behavior, when I'm moving items then some transactions disappear.
Here is default view (when I'm refreshing website, default set)
default_diagram
When i change structure to see all of it (drag&drop states).
right_diagram
And here I'm showing that transactions disappear depends of states position.
wrong_diagram

I'm using:

  • Kubuntu 17.04 x64 4.10.0-38-generic
  • Firefox 56.0 / Chromium 62.0.3202.75

@Buddhima
Copy link
Contributor Author

I have observed same behavior in Chrome on Windows too. Seems to be a limitation of JS library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants