This repository has been archived by the owner on Mar 17, 2020. It is now read-only.
Implementing permissions for workflows #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buddhima
changed the title
bembelimen
reviewed
Oct 22, 2017
| <action name="core.delete" title="JACTION_DELETE" description="JACTION_DELETE_COMPONENT_DESC" /> | ||
| <action name="core.edit" title="JACTION_EDIT" description="JACTION_EDIT_COMPONENT_DESC" /> | ||
| <action name="core.edit.state" title="JACTION_EDITSTATE" description="JACTION_EDITSTATE_COMPONENT_DESC" /> | ||
| <action name="core.edit.own" title="JACTION_EDITOWN" description="JACTION_EDITOWN_COMPONENT_DESC" /> |
There was a problem hiding this comment.
perhaps can add the transition execute action here, too. Then it could be inherit
There was a problem hiding this comment.
I think it's more clearer run.transition stays within transition
bembelimen
reviewed
Oct 22, 2017
| */ | ||
| protected function allowEdit($data = array(), $key = 'id') | ||
| { | ||
| $recordId = (int) isset($data[$key]) ? $data[$key] : 0; |
There was a problem hiding this comment.
Not sure, if the (int) is not executed on the isset
bembelimen
reviewed
Oct 22, 2017
| if ($ownerId == $user->id) | ||
| { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
return !empty($record) && $record->created_by == $user->id;
bembelimen
reviewed
Oct 22, 2017
| { | ||
| $user = Factory::getUser(); | ||
|
|
||
| return ($user->authorise('core.create', $this->extension)); |
bembelimen
reviewed
Oct 22, 2017
|
|
||
| $user = Factory::getUser(); | ||
| $userId = $user->id; | ||
| $isNew = ($this->item->id == 0); |
There was a problem hiding this comment.
!empty($this->item->id)
There was a problem hiding this comment.
I think it should be empty($this->item->id) since we check for new item
Merged
|
In favor of: #157 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #138 .
Summary of Changes
This implementation is to validate user's permission in workflow component. Similar to categories, workflow permission uses it's parent component's permission settings plus its own.
A new permission transition.run is used to indicate which users can perform a particular transition.
Testing Instructions
Setup Joomla CMS. Create user groups and change permissions. Create users for those groups, and check the visibility of different operations based on permissions