Improve startup time drasticaly by caching to disk #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklouwers
force-pushed
the
master
branch
from
41da449 to
fb65665
Compare
|
Hi @jonmosco what are your plans with this PR? |
|
@jonmosco could you check this MR as it will be great to save time opening new console |
|
@franklouwers Curious, with the recent changes made in regards to caching, does this improve the startup time for you? If not, I will revisit this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice that start-up time was pretty long and looked at the caching code.
Although caching is used within a single session, the cache is not used cross-session. People opening lots of shells (like me) get a full kubectl config load every time a new shell is started.
This PR saves the 4 import vars (KUBE_PS1_CONTEXT, KUBE_PS1_KUBECONFIG_CACHE, KUBE_PS1_LAST_TIME and KUBE_PS1_NAMESPACE) to disk, read them from disk at startup, and will update the cache-file every time they change.