Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MediaClass.js #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update MediaClass.js #3

wants to merge 1 commit into from

Conversation

gitastrophe
Copy link

  • adds "click" and "scroll" triggers to re-evaluate element queries
  • separates throttled event triggers from ones that don't require throttling and invokes getMediaFeatures on the unthrottled ones
  • adds checks for element.clientWidth > 0 inside mediaLoop to prevent measurement of hidden elements, which can cause hidden elements to incorrectly match width predicates
  • adds public "refresh" method to enable manual refresh of the MediaClass when the provided event hooks are not sufficient

@gitastrophe
Update MediaClass.js
a49390e 
- adds "click" and "scroll" triggers to re-evaluate element queries
- separates throttled event triggers from ones that don't require throttling and invokes getMediaFeatures on the unthrottled ones
- adds checks for element.clientWidth > 0 inside mediaLoop to prevent measurement of hidden elements, which can cause hidden elements to incorrectly match width predicates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gitastrophe