Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Getx Route Parsing for HTTP/S App Links Compatibility #3067

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

korutx
Copy link
Contributor

@korutx korutx commented Mar 29, 2024

PR Description:

This PR introduces enhancements to Getx's route parsing mechanisms, aiming to improve compatibility with http and https app links. By refining the parsing logic, we ensure that Getx can handle app links more reliably, facilitating the development of more intuitive and user-friendly navigation experiences in Flutter applications.

Changes

  • Route Parsing Improvement: Modified the _parseParams method in parse_route.dart to utilize Uri.tryParse for better extraction of query parameters and path segments from URLs. This adjustment ensures that Getx can accurately parse and route http and https app links.
  • Test Case Update: Added a new test case in parse_route_test.dart to verify the correct parsing and routing of https app links. This test enhances the robustness of our routing logic by ensuring it can handle a variety of URL formats.

Motivation

The motivation behind these changes is to address the challenges developers face when integrating web app links into Flutter applications using Getx. Previously, handling complex URLs with multiple parameters and paths could lead to inconsistencies in parameter parsing. By improving this aspect, we aim to provide a smoother and more predictable routing process, thereby enhancing the overall user experience.

Before/After Screenshots

Not applicable as the changes are primarily under-the-hood improvements.

Documentation and Readme Updates

  • Updated the code documentation and the English readme to reflect the changes made in this PR.

Pre-launch Checklist

  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or @jonataslaw said the PR is test-exempt.
  • All existing and new tests are passing.

@jonataslaw
Copy link
Owner

Thanks for your contribution!
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants