Skip to content

Commit

Permalink
Merge pull request #3141 from Samliangwei/bugfix-memory-leak
Browse files Browse the repository at this point in the history
fix memery leak: '_routesKey' holds the reference when route poped
  • Loading branch information
jonataslaw authored Aug 8, 2024
2 parents fe6cc74 + ceb1abe commit 474af03
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/get_navigation/src/router_report.dart
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ class RouterReportManager<T> {
_routesKey[routeName]?.remove(element);
}
}

_routesKey.remove(routeName);

keysToRemove.clear();
}
Expand Down

1 comment on commit 474af03

@fisforfaheem
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly also make a new release on pub.dev

Please sign in to comment.