-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building on nightly. #749
Conversation
The problem is reproducible using currently Without the fix,
With the update dependency, it builds fine. In the future, I suggest running the tests using P.S. Running the tests using nightly might only seem unnecessary, but it is crucial: when there is another crate depending one way or another - on |
@iddm why the Rust CI cancelled? |
The MSRV of this crate has to be increased as well. Now it is too old and the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for rasing that issue. I think this only needs a bump in the Cargo.lock
. An update of the Cargo.toml
possible but the ~
version requirement is there on purpose. You can simply bump the MSRV everywhere to 1.67 to get the CI going.
The CI is checking on nightly, not sure why you imply otherwise.
Thanks for the response! So I just add the |
It fixes an issue when the crate couldn't be built using nightly due to time dependency. See <rust-lang/rust#125319>.
I created a smaller PR with #750 that for now doesn't touch |
It fixes an issue when the crate couldn't be built using nightly due to time dependency.
See rust-lang/rust#125319.