Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to plot the found path and show the start and the end #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fif911
Copy link

@fif911 fif911 commented Jan 10, 2024

Here is a small update I find to be useful for people who want to test their algorithms.

@fif911
Copy link
Author

fif911 commented Jan 10, 2024

image This is the result of the function call.

@john-science
Copy link
Owner

I have two thoughts on this PR:

  1. The goal of "Example 2" was to show people the fewest possible lines of Python code needed to plot the thing maze. So this new example is not as good from that respect.
  2. Perhaps you can make this a new example between the current "Example 2" and "Example 3" that shows this better copy/paste display example. That seems more useful for the users, as long as it is clearly described as such.
  3. You made a change to the code, but didn't copy/paste the new image into the docs. (So, in your PR the code doesn't match the image below it.)

Does that make sense? Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants