-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(draft) feat: use web workers for placeholder hash calculation #25
base: main
Are you sure you want to change the base?
(draft) feat: use web workers for placeholder hash calculation #25
Conversation
β Deploy Preview for unlazy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
94e3ef9
to
f1e58f0
Compare
Thanks for the effort. There are many moving parts. I'm not sure what implications the async API has yet, since every framework integration depends on a sync API. Thus, it is a breaking change. I will take a deep dive later. |
Currently I'm working on the web worker support for unbuild, because since a library is shipped, we have to add a rollup web worker plugin to the unbuild configuration. Regarding the breaking async changes: I think it should mostly be fine, but I'll have a closer look, when I have time to work on the pull request further. Thanks for your first feedback π |
Some food for thought on this PR:
The bottom line is: I'm OK with the current synchronous implementation. I can only provide limited resources on the worker technology shift. But I'm still open to that one! It just has to be implemented airtight to not break user land. |
I had some fun implementing the I'm not a huge fan, but I think for the moment it's the only way, I'm getting the web worker support to work. Will have a look at it maybe tomorrow, to see what actual performance benefits the web worker approach brings to the table π If the boost is high enough, we can look at some possible fixes for the issue. |
This looks very promising and I appreciate the work being done on this π. Thank you. |
π Linked issue
β Type of change
π Description
π Checklist