Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped dependencies to support connectivity_plus 6.x #65

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

AngeloAvv
Copy link
Contributor

Hey @jogboms , I took the chance to bump some dependencies to support newer versions like connectivity_plus and network_info_plus. I decided to bump to a major since connectivity_plus decided to change all their signatures 😄

I hope this helps. Feel free to ask for changes, I'll be happy to help.

Closes #64

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (356710e) to head (33c3cb1).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           49        49           
=========================================
  Hits            49        49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@jogboms jogboms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work, there's one more edit to make to the README's example

@AngeloAvv
Copy link
Contributor Author

You're right! It should be fine now

@jogboms jogboms merged commit 0193ce8 into jogboms:master Jul 11, 2024
3 checks passed
@AngeloAvv AngeloAvv deleted the connectivity-plus-6.x branch July 11, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

depend on connectivity_plus ^6.0.0
2 participants