Fix disconnect race condition #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: The previous implementation was not taking under consideration that two browsers can disconnect at the same time. Fix: Collect all shard indexes in array of disconnected browsers. Testing Done: - Verify the test sets will be reconnected to the correct shard index and there will be no 1 of 1 test sets, when 2 browsers disconnect at the same time.
|
@joeljeske Can this review be looked at? It fixes #42 |
|
Hi @joeljeske I was also facing this issue in my project, where i have around 10K + test cases and few of them are always skipped (randomly any test case not particular) when the browser is disconnected. I tried consuming this code in my local and it is work fine. Please can you check and merge this PR. Thanks |
|
Hi @juanmendes @sukhbirsinghsaini , did you guys found a workaround to this issue ? We're facing the same one.. |
We applied the patch from this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The previous implementation was not taking under
consideration that two browsers can disconnect at
the same time.
Fix:
Collect all shard indexes in array of disconnected browsers.
Testing Done:
shard index and there will be no 1 of 1 test sets, when
2 browsers disconnect at the same time.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
If two browsers disconnect at the same time the second will create new shard index
and will cause 1 of 1 test set.
What is the new behavior (if this is a feature change)?
Each disconnected browser shard index will be stored in disconnected browsers array
and when the new browsers try to reconnect they will get their old shard indexes, ensuring
no 1 of 1 test sets.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No breaking changes.
Other information: