Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable telemetry opt-out #254 #402

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gardner
Copy link

@gardner gardner commented Mar 30, 2024

Users can opt out of telemetry by setting the environment variable CREWAI_TELEMETRY_OPT_OUT

Fixes:

This branch has been published to https://pypi.org/project/crewai-clean for testing.

@raghav135
Copy link

As an software architect within a bank which has tons of firewall, such requests for enabling firewall will never get approved , without opting out feature, we will get errors in logs, and we will have a sub standard experience. Unfortunately for us, it would be a no go with crewai if we don't have an opt out of telemetry.

@ZQ-Dev8
Copy link

ZQ-Dev8 commented Apr 18, 2024

+1 on disabling telemetry for running in airgapped environments, any updates on this?

@arnaudgelas
Copy link

@joaomdmoura Can you have a look at this one, please?
Note in an enterprise environment this is a blocking point

@CodiumAI-Agent
Copy link

PR Review 🔍

⏱️ Estimated effort to review [1-5]

2, because the PR is small and the changes are straightforward, but it requires careful consideration of the environment variable handling and its impact on the telemetry system.

🧪 Relevant tests

No

⚡ Possible issues

Possible Bug: The environment variable check os.environ.get("CREWAI_TELEMETRY_OPT_OUT", False) will not work as intended because os.environ.get will return a string and not a boolean. This could lead to the telemetry not being disabled even if the environment variable is set.

🔒 Security concerns

No

Code feedback:
relevant filesrc/crewai/telemetry/telemetry.py
suggestion      

Consider explicitly checking for a specific string value to determine if telemetry should be disabled. This ensures that setting the environment variable to any string will not unintentionally disable telemetry. For example, you could check if the environment variable is set to 'true' or '1'. [important]

relevant lineif os.environ.get("CREWAI_TELEMETRY_OPT_OUT", False):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants