Skip to content
This repository has been archived by the owner on May 2, 2021. It is now read-only.

Use latest Avalonia 0.9.1 #4

Merged
merged 6 commits into from
Jan 16, 2020
Merged

Use latest Avalonia 0.9.1 #4

merged 6 commits into from
Jan 16, 2020

Conversation

worldbeater
Copy link
Contributor

@worldbeater worldbeater commented Jan 15, 2020

Updated the projects to use latest Avalonia and lifetimes API. Also added a new SourceUriRaw attached property to allow folks to write somewhat like the following directly in XAML, without bindings:

<Image Stretch="UniformToFill" 
       gif:GifImage.SourceUriRaw="resm:AvaloniaGif.Demo.Images.loader.gif"/>

Assuming the loader.gif is located inside the same assembly as EmbeddedResource. This can be sometimes useful, e.g. when the view models live in a separate project and know nothing about the currently used GUI framework

@worldbeater worldbeater requested a review from jmacato January 15, 2020 20:08
Copy link
Owner

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @worldbeater! :D Just need to correct some nits :) I haven't been able to maintain this repo, and we still need rendering changes in Avalonia as described by @kekekeks in AvaloniaUI/Avalonia#3014 to bringout the best performance out of this library.

AvaloniaGif.Demo/MainWindow.xaml Outdated Show resolved Hide resolved
AvaloniaGif.Demo/MainWindowViewModel.cs Show resolved Hide resolved
@worldbeater
Copy link
Contributor Author

Thanks for taking the time to review this @jmacato! Applied the suggested tweak and added a demo.gif to README.md to give folks more context about what they are looking at. Decided to add an animated circle progress bar to a sample app I'm working on in my spare time, and your implementation just worked 👍 (haven't noticed any performance issues yet btw)

@jmacato
Copy link
Owner

jmacato commented Jan 16, 2020

@worldbeater Awesome! :D There's still some issues that i want to fix when i get some free time, @Kermalis 's issue on #2 is a high-priority and im still struggling on why that happens.

Copy link
Owner

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmacato jmacato merged commit 342a784 into jmacato:master Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants