-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @worldbeater! :D Just need to correct some nits :) I haven't been able to maintain this repo, and we still need rendering changes in Avalonia as described by @kekekeks in AvaloniaUI/Avalonia#3014 to bringout the best performance out of this library.
Thanks for taking the time to review this @jmacato! Applied the suggested tweak and added a |
@worldbeater Awesome! :D There's still some issues that i want to fix when i get some free time, @Kermalis 's issue on #2 is a high-priority and im still struggling on why that happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Updated the projects to use latest Avalonia and lifetimes API. Also added a new
SourceUriRaw
attached property to allow folks to write somewhat like the following directly in XAML, without bindings:Assuming the
loader.gif
is located inside the same assembly asEmbeddedResource
. This can be sometimes useful, e.g. when the view models live in a separate project and know nothing about the currently used GUI framework