Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TODO and use Log mechanism to report table-design and runtime #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjanssen2
Copy link
Member

@sjanssen2 sjanssen2 commented May 12, 2022

previously, I directly printed the table design and runtime information to standard error. However, we do have a great logging mechanism which we should use here. Thus, the user can pick a log level and see this message depending on this log level on std::cout

Copy link
Member

@kmaibach kmaibach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which log level do I have to select to get this message printed?
And could we include that information in the help page (or any other documentation place) somehow?

@sjanssen2
Copy link
Member Author

I agree, documentation is our weak spot. However, I wonder what the best place would be to hint towards this feature?

@kmaibach
Copy link
Member

kmaibach commented May 12, 2022

That's a good question. As I don't know any other place, the help page is the only thing I can think of. But since this "warning" is quite important I believe it should be mentioned somewhere that's easily accessible.
Or - and that would mean quite a lot of work - we start writing a detailed documentation where the help page can reference to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants