Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move non-local comment to its correct place #805

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

move non-local comment to its correct place #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52dce47
remove non local comment
jelgun Aug 6, 2023
58aa48c
add the explanation to loadAccount documentation
jelgun Aug 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions ...t/java/sip/communicator/impl/protocol/gibberish/ProtocolProviderFactoryGibberishImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,6 @@ public AccountID installAccount( String userIDStr,
throw new IllegalStateException(
"An account for id " + userIDStr + " was already installed!");

//first store the account and only then load it as the load generates
//an osgi event, the osgi event triggers (through the UI) a call to the
//ProtocolProviderService.register() method and it needs to acces
//the configuration service and check for a stored password.
this.storeAccount(accountID, false);

accountID = loadAccount(accountProperties);
Expand Down
3 changes: 2 additions & 1 deletion ...col/src/main/java/net/java/sip/communicator/service/protocol/ProtocolProviderFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,8 @@ protected String loadPassword(BundleContext bundleContext,
/**
* Initializes and creates an account corresponding to the specified
* accountProperties and registers the resulting ProtocolProvider in the
* <tt>context</tt> BundleContext parameter. This method has a persistent
* <tt>context</tt> BundleContext parameter via an osgi event (which needs to acces the
* configuration service and check for a stored password). This method has a persistent
* effect. Once created the resulting account will remain installed until
* removed through the uninstallAccount method.
*
Expand Down