Remove Slot Monotic Constraint #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esemeniuc
reviewed
Feb 21, 2024
| } | ||
| if let Err(e) = slot_sender.send(slot.slot) | ||
| { | ||
| error!("error sending slot: {e}"); |
There was a problem hiding this comment.
Suggested change
| error!("error sending slot: {e}"); | |
| error!("error sending slot {}: {e}", slot.slot); |
|
Do we choose the rpc with the highest slot? |
buffalu
reviewed
Feb 21, 2024
| error!("error sending slot: {e}"); | ||
| break; | ||
| } | ||
| if let Err(e) = slot_sender.send(slot.slot) |
There was a problem hiding this comment.
this is not going to work super well if RPCs are running behind. note the following graph from our internal + external RPC cluster:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slots from RPCs were restrained to be monotonically increasing. However, during temporary forks, this can interrupt proper packet forwarding.