Exclude Epoch Boundary from Health Check #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalu
reviewed
Jan 29, 2024
segfaultdoc
reviewed
Jan 29, 2024
buffalu
reviewed
Jan 29, 2024
esemeniuc
reviewed
Feb 5, 2024
| // Don't perform health updates within +/- 75 slots of epoch boundary | ||
| // Note: This is not necessarily correct for local testing | ||
| let slot_index = slot % DEFAULT_SLOTS_PER_EPOCH; | ||
| outside_epoch_boundary = 75 < slot_index && slot_index < (DEFAULT_SLOTS_PER_EPOCH - 75); |
There was a problem hiding this comment.
would be good to add a const for 75 with a comment on why the specific value
buffalu
reviewed
Feb 5, 2024
| "relayer-health-state", | ||
| ("health_state", new_health_state, i64) | ||
| ); | ||
| if outside_epoch_boundary { |
There was a problem hiding this comment.
can you move the check of outside_epoch_boundary into the match statement/if/else for health state? may be helpful to continue emitting data points during that time
buffalu
reviewed
Feb 5, 2024
| } | ||
| recv(slot_receiver) -> maybe_slot => { | ||
| let slot = maybe_slot.expect("error receiving slot, exiting"); | ||
| // Don't perform health updates within +/- 75 slots of epoch boundary |
There was a problem hiding this comment.
thoughts on moving this logic to the health state stuff above?
esemeniuc
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.