Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit of code improvement #27289

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

A bit of code improvement #27289

wants to merge 10 commits into from

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Sep 14, 2024

  • Some code quality.
  • One fix for fakeKeytool option
  • Review of the angular generator to only keep methods used in .ejs in generator.ts (also, removal of totally unused methods)

First try to follow #27294


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl
Copy link
Contributor Author

Tcharl commented Sep 15, 2024

Is it considered as correct? I'm a bit reluctant to continue this PR to improve the remaining files (passing over each generator with the same improvments)

generators/base/types.d.ts Outdated Show resolved Hide resolved
Copy link
Member

@mshima mshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea is to drop lib/jhipster/index.js.
Choice value usage will be at the generator it's declared.
It can be replaced with something like springBootCommand.configs.authenticationType.choices.jwt.value.

Choices is an array, we should support object.

@Tcharl
Copy link
Contributor Author

Tcharl commented Sep 16, 2024

My idea is to drop lib/jhipster/index.js. Choice value usage will be at the generator it's declared. It can be replaced with something like springBootCommand.configs.authenticationType.choices.jwt.value.

Choices is an array, we should support object.

Can we simplify? application.authenticationType ?
The reasoning behind is: if generator-angular/type.d.ts#AngularApplication need something coming from server it should extends SpringBootServerApplication and being taken as a generic default class AngularGenerator extends BaseApplicationGenerator<AngularApplication, AngularEntity>. Does it makes sense?

@Tcharl Tcharl mentioned this pull request Oct 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants