Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - update password reset page to use only react-form capabilities #19560

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Tcharl
Copy link
Contributor

@Tcharl Tcharl commented Aug 28, 2022

need discussion.

Updates standard forms to use wrapped leaf element instead of a form wrapper.

Pro:

  • let the user mix his own components with JH wrapped elements
  • compatible with latest react version (which forbids the use of useState and useEffect within a lib from what I've tested)
  • use something that he better knows to use
  • No need to maintain the react-jhipster forms code which is a bit... difficult to understand

Con:

  • 4 more lines by form entry

To use in combination with jhipster/react-jhipster#87


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl Tcharl requested a review from deepu105 August 28, 2022 17:03
@Tcharl Tcharl force-pushed the remove_validated_forms branch 3 times, most recently from 137306e to c2e247e Compare August 28, 2022 20:05
@Tcharl Tcharl changed the title update password reset page to use only react-form capabilities WIP - update password reset page to use only react-form capabilities Sep 5, 2022
@Tcharl
Copy link
Contributor Author

Tcharl commented Sep 5, 2022

@deepu105 @mshima what do you think about this one? A little bit easier to understand than the reflection-intensive former library IMO, but I wanted to know your opinion before going further

@Tcharl Tcharl force-pushed the remove_validated_forms branch 2 times, most recently from 2cf4f35 to 41a57c3 Compare September 5, 2022 21:06
@mshima
Copy link
Member

mshima commented Sep 5, 2022

I’m not react expert, but looks like it will make react-jhipster more generic and reusable.

@Tcharl Tcharl force-pushed the remove_validated_forms branch 4 times, most recently from 7cf1c74 to 7ffd70c Compare September 12, 2022 08:39
@Tcharl Tcharl linked an issue Sep 12, 2022 that may be closed by this pull request
1 task
@Tcharl Tcharl marked this pull request as draft September 12, 2022 08:50
@hide212131
Copy link
Contributor

I'm hopeful for the resolution of this PR.
To contribute, even in a small way, I have rebased @Tcharl's branches (generator-jhipster, react-jhipster) with the latest main branch and fixed several issues. (I understand that, as they are in the Draft phase, implementations are still underway except for textinput.)
Would it be possible to move forward with this PR?
I would be delighted to apply this solution to the entity's update page once this issue is resolved.

@DanielFran
Copy link
Member

Please go ahead with a new PR if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use state and effects within react-jhipster
4 participants