Update Package to Use Floating-UI instead of PopperJS #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey sorry. I just noticed this PR now when going over this repo. I'll review this in the next week and let you know. |
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the PopperJS package seems to have a lot of trouble working with Sveltekit and requires a ton of unnecessary configuration to get working properly. See Rich's comment on this issue
Floating-ui seems to fix all of these issues with almost no functional changes to this package, and only one small breaking change. (Space Along prop had to be removed.)
So, I updated the package to use floating-ui instead. I also updated the documentation to reflect these changes. Lastly, I added two new props role and id for accessibility.